[pallet-revive] implement the call data copy API by xermicus · Pull Request #6880 · paritytech/polkadot-sdk

xermicus · 2024-12-13T14:02:25Z

This PR implements the call data copy API by adjusting the input method.

Closes #6770

Signed-off-by: xermicus <cyrill@parity.io>

xermicus · 2024-12-13T14:02:30Z

/cmd prdoc --audience runtime_dev --bump minor

github-actions · 2024-12-13T14:04:49Z

Command "prdoc --audience runtime_dev --bump minor" has failed ❌! See logs here

xermicus · 2024-12-13T14:05:07Z

bot fmt

command-bot · 2024-12-13T14:05:13Z

@xermicus https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7915930 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 9-516dd871-ccce-4c89-b412-56e73fc92728 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2024-12-13T14:05:58Z

@xermicus Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7915930 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7915930/artifacts/download.

xermicus · 2024-12-13T14:06:09Z

/cmd prdoc --audience runtime_dev --bump major

github-actions · 2024-12-13T14:09:21Z

Command "prdoc --audience runtime_dev --bump major" has failed ❌! See logs here

Signed-off-by: xermicus <cyrill@parity.io>

xermicus · 2024-12-13T14:12:06Z

/cmd bench --runtime dev --pallet pallet_revive

github-actions · 2024-12-13T14:15:56Z

Command "bench --runtime dev --pallet pallet_revive" has started 🚀 See logs here

…llet_revive'

github-actions · 2024-12-13T15:04:59Z

Command "bench --runtime dev --pallet pallet_revive" has finished ✅ See logs here

Details

Subweight results:

File	Extrinsic	Old	New	Change [%]
cumulus/pallets/collator-selection/src/weights.rs	leave_intent	-	-	ERROR
cumulus/pallets/collator-selection/src/weights.rs	new_session	-	-	ERROR
cumulus/pallets/collator-selection/src/weights.rs	register_as_candidate	-	-	ERROR
cumulus/pallets/collator-selection/src/weights.rs	set_invulnerables	-	-	ERROR
cumulus/pallets/collator-selection/src/weights.rs	take_candidate_slot	-	-	ERROR
cumulus/pallets/collator-selection/src/weights.rs	update_bond	-	-	ERROR
cumulus/parachains/runtimes/assets/asset-hub-rococo/src/weights/pallet_collator_selection.rs	take_candidate_slot	-	-	ERROR
cumulus/parachains/runtimes/assets/asset-hub-rococo/src/weights/pallet_collator_selection.rs	update_bond	-	-	ERROR
cumulus/parachains/runtimes/assets/asset-hub-westend/src/weights/pallet_collator_selection.rs	take_candidate_slot	-	-	ERROR
cumulus/parachains/runtimes/assets/asset-hub-westend/src/weights/pallet_collator_selection.rs	update_bond	-	-	ERROR
cumulus/parachains/runtimes/bridge-hubs/bridge-hub-rococo/src/weights/pallet_collator_selection.rs	take_candidate_slot	-	-	ERROR
cumulus/parachains/runtimes/bridge-hubs/bridge-hub-rococo/src/weights/pallet_collator_selection.rs	update_bond	-	-	ERROR
cumulus/parachains/runtimes/bridge-hubs/bridge-hub-westend/src/weights/pallet_collator_selection.rs	take_candidate_slot	-	-	ERROR
cumulus/parachains/runtimes/bridge-hubs/bridge-hub-westend/src/weights/pallet_collator_selection.rs	update_bond	-	-	ERROR
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_collator_selection.rs	take_candidate_slot	-	-	ERROR
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_collator_selection.rs	update_bond	-	-	ERROR
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_core_fellowship_ambassador_core.rs	promote_fast	-	-	ERROR
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_core_fellowship_fellowship_core.rs	promote_fast	-	-	ERROR
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_preimage.rs	ensure_updated	-	-	ERROR
cumulus/parachains/runtimes/people/people-rococo/src/weights/pallet_collator_selection.rs	take_candidate_slot	-	-	ERROR
cumulus/parachains/runtimes/people/people-rococo/src/weights/pallet_collator_selection.rs	update_bond	-	-	ERROR
cumulus/parachains/runtimes/people/people-westend/src/weights/pallet_collator_selection.rs	take_candidate_slot	-	-	ERROR
cumulus/parachains/runtimes/people/people-westend/src/weights/pallet_collator_selection.rs	update_bond	-	-	ERROR
polkadot/runtime/westend/src/weights/pallet_preimage.rs	ensure_updated	-	-	ERROR
substrate/frame/election-provider-support/src/weights.rs	phragmen	-	-	ERROR
substrate/frame/election-provider-support/src/weights.rs	phragmms	-	-	ERROR
substrate/frame/revive/src/weights.rs	seal_address	315.00ns	351.00ns	+11.43
substrate/frame/revive/src/weights.rs	seal_caller_is_origin	422.00ns	467.00ns	+10.66
substrate/frame/revive/src/weights.rs	set_transient_storage_full	2.00us	2.14us	+6.85
substrate/frame/revive/src/weights.rs	seal_ecdsa_recover	48.96us	51.83us	+5.86
substrate/frame/revive/src/weights.rs	seal_origin	292.00ns	275.00ns	-5.82
substrate/frame/revive/src/weights.rs	noop_host_fn	281.18us	254.88us	-9.35
substrate/frame/revive/src/weights.rs	seal_minimum_balance	318.00ns	284.00ns	-10.69
substrate/frame/revive/src/weights.rs	seal_own_code_hash	318.00ns	280.00ns	-11.95
substrate/frame/revive/src/weights.rs	seal_copy_to_contract		52.97us	Added
substrate/frame/revive/src/weights.rs	seal_call_data_copy		30.01us	Added

Command output:

✅ Successful benchmarks of runtimes/pallets:
-- dev: ['pallet_revive']

Signed-off-by: xermicus <cyrill@parity.io>

paritytech-workflow-stopper · 2024-12-16T10:20:25Z

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/12349718165
Failed job name: test-linux-stable-no-try-runtime

Signed-off-by: xermicus <cyrill@parity.io>

athei

Why are those PolkaVM files getting so much smaller? They were already 64bit before, right?

substrate/frame/revive/uapi/src/host.rs

xermicus · 2024-12-16T13:07:45Z

Why are those PolkaVM files getting so much smaller? They were already 64bit before, right?

Might be that the solc optimizer was still disabled if they were compiled with the remix backend.

Signed-off-by: xermicus <cyrill@parity.io>

This PR implements the call data copy API by adjusting the input method. Closes paritytech#6770 --------- Signed-off-by: xermicus <cyrill@parity.io> Co-authored-by: command-bot <>

xermicus added 7 commits December 13, 2024 11:19

wip

cbe7c84

Signed-off-by: xermicus <cyrill@parity.io>

Merge branch 'master' into cl/calldatacopy

bdfa162

fix the input macro

b40f2bb

Signed-off-by: xermicus <cyrill@parity.io>

remove input fn

e3b4cbe

Signed-off-by: xermicus <cyrill@parity.io>

fixture

edbfdea

Signed-off-by: xermicus <cyrill@parity.io>

comment

6796023

Signed-off-by: xermicus <cyrill@parity.io>

bench

3acb518

Signed-off-by: xermicus <cyrill@parity.io>

xermicus added R0-no-crate-publish-required The change does not require any crates to be re-published. T7-smart_contracts This PR/Issue is related to smart contracts. labels Dec 13, 2024

xermicus requested review from athei and pgherveou December 13, 2024 14:02

".git/.scripts/commands/fmt/fmt.sh"

bb636ea

Merge branch 'master' into cl/calldatacopy

e16e1ef

prdoc

6e60ca1

Signed-off-by: xermicus <cyrill@parity.io>

Update from xermicus running command 'bench --runtime dev --pallet pa…

61de25c

…llet_revive'

xermicus added 3 commits December 13, 2024 18:01

Merge branch 'master' into cl/calldatacopy

9061baa

fix merge

664f012

Signed-off-by: xermicus <cyrill@parity.io>

Merge branch 'master' into cl/calldatacopy

2c452c7

rebuild fixtures

422a37a

Signed-off-by: xermicus <cyrill@parity.io>

xermicus added 2 commits December 16, 2024 12:26

Merge branch 'master' into cl/calldatacopy

ebbceff

fix move

e2e294f

Signed-off-by: xermicus <cyrill@parity.io>

athei reviewed Dec 16, 2024

View reviewed changes

substrate/frame/revive/uapi/src/host.rs Outdated Show resolved Hide resolved

remove double ref

2fa011b

Signed-off-by: xermicus <cyrill@parity.io>

athei approved these changes Dec 16, 2024

View reviewed changes

Merge branch 'master' into cl/calldatacopy

9fc0554

pgherveou approved these changes Dec 17, 2024

View reviewed changes

Merge branch 'master' into cl/calldatacopy

009307c

xermicus enabled auto-merge December 18, 2024 06:49

xermicus added this pull request to the merge queue Dec 18, 2024

Merged via the queue into master with commit 4a0e3f6 Dec 18, 2024
140 of 142 checks passed

xermicus deleted the cl/calldatacopy branch December 18, 2024 07:59

ggwpez mentioned this pull request Jun 4, 2025

Bump to stable2503 polkadot-fellows/runtimes#711

Merged

7 tasks

github-actions bot mentioned this pull request Jun 10, 2025

Update polkadot-sdk from stable2412 to stable2503 moondance-labs/tanssi#1087

Closed

This was referenced Jul 16, 2025

Update polkadot-sdk from stable2412 to stable2503 moonbeam-foundation/moonbeam#3362

Closed

Update polkadot-sdk from stable2412 to stable2503-7 moonbeam-foundation/moonbeam#3363

Closed

Conversation

xermicus commented Dec 13, 2024

Uh oh!

xermicus commented Dec 13, 2024

Uh oh!

github-actions bot commented Dec 13, 2024

Uh oh!

xermicus commented Dec 13, 2024

Uh oh!

command-bot bot commented Dec 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented Dec 13, 2024

Uh oh!

xermicus commented Dec 13, 2024

Uh oh!

github-actions bot commented Dec 13, 2024

Uh oh!

xermicus commented Dec 13, 2024

Uh oh!

github-actions bot commented Dec 13, 2024

Uh oh!

github-actions bot commented Dec 13, 2024

Uh oh!

paritytech-workflow-stopper bot commented Dec 16, 2024

Uh oh!

athei left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

xermicus commented Dec 16, 2024

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

command-bot bot commented Dec 13, 2024 •

edited

Loading